Richard Chan comments

Results 15 comments of


                                            Richard Chan

Dialog: high contrast black and white box-shadow on footer

Hi team - following up on this issue. Any updates on this?

Dialog: high contrast black and white box-shadow on footer

Hi @nnaydenow - an issue seems to have come up after this fix (border top). See below. https://sap.github.io/ui5-webcomponents-react/?path=/docs/modals-popovers-dialog--default-story&globals=theme:sap_horizon_hcb ![SCR-20220912-fm6](https://user-images.githubusercontent.com/11576789/189726973-5a98ae79-fab8-49dd-876c-2512da7f5a54.png) ![SCR-20220912-fng](https://user-images.githubusercontent.com/11576789/189726983-ea03d4d8-eb5b-466f-b903-2bee055868d0.png)

[SF][ViewSettingsDialog] - setConfirmedSettings lifecycle

Hi team - following up on this issue. Any news?

[SF][ViewSettingsDialog] - setConfirmedSettings lifecycle

Hi team - following up on this issue. Any updates?

fix(ui5-view-settings-dialog): update setConfirmedSettings param string type from String to Object and description sample code

Hi @NHristov-sap - could you please review at your earliest convenience? Thanks!

fix(ui5-view-settings-dialog): update setConfirmedSettings param string type from String to Object and description sample code

Hi @tsanislavgatev - could you please review one more time? Thanks!

fix(ui5-view-settings-dialog): update setConfirmedSettings param string type from String to Object and description sample code

@tsanislavgatev @NHristov-sap - could you guys please approve running workflows?

fix(ui5-view-settings-dialog): update setConfirmedSettings param string type from String to Object and description sample code

> @rchrdchn could you please rebase from main, I have updated chrome driver and the tests should pass Done - hoping I did it correctly 🙂

Dialog: high contrast black and white box-shadow on footer

hi @nnaydenow @Todor-ads - what's the status on this issue? it's been a few months since the last update.

[SF][ViewSettingsDialog] - setConfirmedSettings lifecycle

hi @tsanislavgatev - could you share the status on this issue, please?