Roberto J Catalan
Roberto J Catalan
This PR solves issue #149 Swap tests were dividied into Pool Cases, and also Swap Cases. Then, each Swap Case is executed in each Pool Case. This is why this...
The PR should include the corresponding Swap tests from [Uniswap v3 core](https://github.com/Uniswap/v3-core/blob/main/test/UniswapV3Pool.swaps.spec.ts#L450C12-L450C12). The tests should be located [here](https://github.com/lambdaclass/yet-another-swap/blob/main/src/tests/test_contracts/test_yas_pool.cairo#L467C15-L467C15). Blue Ticks are ready to merge, Purple Ticks are already merged: -...
The PR should include the corresponding Mint tests from [Uniswap v3 core](https://github.com/Uniswap/v3-core/blob/main/test/UniswapV3Pool.swaps.spec.ts). The tests should be located [here](https://github.com/lambdaclass/yet-another-swap/blob/main/src/tests/test_contracts/test_yas_pool.cairo#L467C15-L467C15).
Include a target in the Makefile called `declare-testnet` to declare the following contracts: - Router - YASPool - YASFactory This target should use `starkli` to interact with the wallet and...
Implement collect_protocol to YASPool. You can check out the code from [UniswapV3 Core](https://github.com/Uniswap/v3-core/blob/main/contracts/UniswapV3Pool.sol#L848).
Implement set_fee_protocol to YASPool. You can check out the code from [UniswapV3 Core](https://github.com/Uniswap/v3-core/blob/main/contracts/UniswapV3Pool.sol#L837).
To update to the newest Cairo version we will need to: - Update the scarb version to the latest - Update `make deps` - Update the README with the appropriate...
The refactor should replace this [pattern matching](https://github.com/lambdaclass/yet-another-swap/blob/main/crates/yas_core/src/contracts/yas_pool.cairo#L645-L650) for the use of the ```?``` operator. The idea is to test if it panics exactly the same way so we can be...