Riccardo Cardin
Riccardo Cardin
Can I take the `Access-Control-Max-Age` header?
@rossabaker, I'm taking the implementation of the header `Age` as a reference. Is it correct? The only difference is the [specification](https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Access-Control-Max-Age#directives) says the header can have a value equal to...
@rossabaker, I'm stuck. If possible, I would use the "coaching card" right now. [Here](https://github.com/rcardin/http4s/blob/feature/5010--access-control-max-age-header/core/shared/src/main/scala/org/http4s/headers/%60Access-Control-Max-Age%60.scala) is what I've done until now. I cannot understand how to call the `Header.createRender` with an...
Many thanks, @pektinasen 🥇 ! I will try it asap.
@pektinasen, did you mean something like this? ```scala implicit val headerInstance: Header[`Access-Control-Max-Age`, Header.Single] = Header.createRendered( ci"Access-Control-Max-Age", { case Cache(age) => age case NoCaching => -1 }, parse ) ```
I will take the `Access-Control-Allow-Methods` header, if I can :) Let me know.
@rossabaker, no rush. The PRs will not go anywhere :P
@mfirry, I read the header documentation on the Mozilla site, and it seems you're right. I don't think that _code reuse_ is a good choice. The two headers are similar...
Guys, I'll take `Device-Memory`, if available.
Guys, the `Access-Control-Max-Age` was already merged: https://github.com/http4s/http4s/pull/5171. Can anyone check it as "done" in the tasks list?