Rob Barreca issues

Results 72 issues of


                                            Rob Barreca

No validation error when submitting a required select component with an empty option

It's probably just user error, but I can't figure out how to make a required select component with an empty option. It doesn't trigger any Polaris validation, rather just gets...

Remove consignment, Quickbooks, and other unused code

WIP

When reducing "delivered" qty or deleting an order item, don't return that inventory to the "available" pool

**Is your feature request related to a problem? Please describe.** A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] **Describe the solution you'd...

Error when updating a credit card order when that payment was removed from organization

**Describe the bug** TBD **To Reproduce** 1. Possibly make order, remove payment method, update order 1. See error 'RuntimeError: No chargable accounts found' **Expected behavior** A clear and concise description...

Error when merging an order with fractional order item quantity if that product has zero available inventory

**Describe the bug** Validation failed error when merging an order with fractional order item quantity if that product has zero available inventory. **To Reproduce** Steps to reproduce the behavior: 1....

Prod/staging should have config.assets.compile = false

You set your `config.assets.compile = true` in production. This can negatively impact the performance of your application. For more information can be found in this article: https://devcenter.heroku.com/articles/rails-asset-pipeline#compile-set-to-true-in-production

Move to rails_helper

https://relishapp.com/rspec/rspec-rails/v/3-0/docs/upgrade

WIP for Ruby 2.4 and Rails 4.2

Issues: - Ransack monkey patch. Do we need to refactor all those distinct: true - Can't upgrade Ruby to 2.5 without upgrading Devise

Rob Barreca