Petr Vítek
Petr Vítek
I ended up using echo logger functionality since i can provide log function and the middleware stuff is handled by echo. so in echo i setup: `app.echo.Use(rest.LoggerMiddleware(&log.Logger))` where log.Logger is...
> To be honest, I do not understand why `c.Error(err)` is even called given that the `err` is returned by the middleware. Shouldn't we simply remove this line? > >...
Okie, changed this to implement the removal. I've once again today run into issue with this so I hope this is merged & released soon :-)
> Tests are failing. Oh well it actually depends on the http status code being already set (for example by error handler.. :disappointed: ). So this middleware would **require** some...
> Well, it looks like the `TestStatusError` test needs to be updated to properly reflect those changes. Sure I can fix the tests, if that's the way to go. Not...
@MrAlias I disagree that it's issue that should be solved in error handler, that is a workaround at best, because the real issue is calling error handler multiple times for...
As long as it's addressed somehow I'm happy :-)
Any blocker for this one? Got burned by empty switch case and wanted to find linter for it :-)
Oki that seems great, will try to get it in code, but that will mean probably to ditch the $script log constants
That is unfortunate. Didn't realize there is a risk of that. This issue is still not resolved mainly because of -> https://github.com/open-telemetry/opentelemetry-go-contrib/pull/4420#issuecomment-1893444450 I don't really know how to move forward...