Giovanni Bajo

Results 152 comments of Giovanni Bajo

@ianlancetaylor isn't `syscall.ForkLock` part of Go1 api? It's a public member of the `syscall` package and part of `go1.txt`. How do you propose that a CL change mutex type without...

@bradfitz I'm not sure I follow what you're suggesting. `ForkLock` always guards a non-atomic sequence of two syscalls, usually the first creates a file descriptor (just like `syscall.Socket` or `syscall.Pipe`)...

Switched to draft as I found a regression in a module with this which I cannot understand.

I think it's this one: https://modarchive.org/index.php?request=view_by_moduleid&query=36595 After the intro, in the chorus there are some high pitch notes that sound distorted with my commit

Yesterday I got confused about all the cycles shift. I revisited the code today and realized that it's still necessary to keep a 33-bit compare / count now that we...

I changed the implementation to do the check in `CPU::step` so that it should be cycle-accurate in any case, including stalls.

I've pushed a commit that switches to doing the timer interrupt check only in `instructionEpilogue` as requested by the review. I can't personally vet it's correct. It does pass the...

> I happened across another bit of code that further complicates things. The recompiler can emit code that directly modifies the clock counter: > > https://github.com/higan-emu/ares/blob/ed4d21d7a35ee1f1e3e4ba44f40781d2026bffb3/ares/n64/cpu/recompiler.cpp#L39-L44 > > > The...

Given that it's just "make", do we really need to write that?