Sojin Park

Results 167 comments of Sojin Park

Actually we manually have written all the jsdocs so there may be some mistakes 😢 thanks for your contribution!

It was by intention that the source code, test code, and documentation are put in the same directory. I thought they will always be edited together, so putting them as...

Yes, I think we might try this. I think merging the pull request as is is not bad, so I will merge it right now. Feel free to open another...

In my opinion, since `top`, `left`, `bottom`, and `right` have no effect when `position` is not given, they should always go together. So in the source code above, every call...

Yes, I agree in @HoseungJang ’s opinion. And I think we should deprecated the API where `position` value is omitted.

I think it will be nice to have absolute, fixed, sticky functions in our emotion utils. cc. @HoseungJang

This seems to be fixed from v0.73.0. https://github.com/facebook/metro/commit/db19b06bdd6d2fbbe109e4f3be4b3af3489c1f1c

Actually, when using `ElementType` from `@toss/utility-types`, we should use it as a regular dependency (not a devDependency). Otherwise, the returned type from `pick` or `omit` would not be inferred. (Because...