Eivind Gamst

Results 12 comments of Eivind Gamst

Just add `#[cfg(feature = "wayland_frontend")]` on all the methods it complains about ;)

Seems that github actions is not allowing clippy to run properly here?

I guess I will wait for that then :smiling_face_with_tear:

Just a minor hiccup :see_no_evil:

Now supports serial handling and popup surface handling

@PolyMeilex thanks for the ping, I hope it is alright that I request a review

> input-method heavy_check_mark 2 > text-input heavy_check_mark 3 > virtual-keyboard heavy_check_mark 1 I cannot edit, but these are the correct versions

Agreed, but I think most people refer to the revisions \_('_')_/ ref: https://gitlab.freedesktop.org/wayland/wayland-protocols/-/issues/39#implementation-matrix Maybe have both?

run these on your branch and correct them btw: `cargo clippy --features "test_all_features" -- -D warnings` `cargo fmt --all -- --check` `cargo hack check --each-feature --no-dev-deps --exclude-features use_bindgen`

LGTM otherwise, someone that knows xdg positioner should probably have a look at the positioner and popup part