Rich Alimi
Rich Alimi
An example run: https://github.com/google/chrome-ssh-agent/runs/7818213408 The error we get is "timeout waiting for Xvfb", and this happens for the end-to-end tests. It happens during initialization of Selenium (https://github.com/tebeka/selenium/blob/e9100b7f5ac11727841302026707e3961ba14712/service.go#L377).
Implement a mutex around [BigStorage](https://github.com/google/chrome-ssh-agent/blob/master/go/chrome/bigstorage.go) operations to prevent cleaning up chunks that may be referenced. This is now technically possible since `Delete()` is no longer an atomic operation; it deletes...
Chrome is requiring all extensions to move to Manifest V3 in Chrome, which means using [Service Workers](https://developer.chrome.com/docs/extensions/mv3/intro/mv3-overview/#service-workers) instead of a persistent background page. Service Workers have the Chrome will forcibly...
js.Wrapper was removed in Go 1.18. Thus, this library fails to build under Go 1.18 due to e.g., https://github.com/norunners/vert/blob/main/value.go#L30. See https://github.com/golang/go/issues/50310 for some additional background; the proposal to reinstate it...
From a review left on the Chrome Webstore: "would be great to be able to activate by default the ssh-agent option in the chrome shell."
@vapier [commented](https://github.com/google/chrome-ssh-agent/issues/40#issuecomment-1236489292) that its worth considering merging this into the Secure Shell extension itself. Leaving this open to track the issue and see what that might entail.
From a review left on the Chrome Webstore: "Minor feature request: For each unencrypted key, have an option to load it automatically."
This helps in cases where Xvfb timeout may be slower. See https://github.com/google/chrome-ssh-agent/issues/30 for an example of where the existing 3 seconds is not sufficient.