rakamoviz

defaultCommandHandler bug, adding "undefined" to array of evtsToDispatch

1

https://github.com/adrai/node-cqrs-domain/blob/4e70105b11a444b02c12f2850c61242b4998361c/lib/defaultCommandHandler.js#L896 There should be a check like this: https://github.com/rakamoviz/node-cqrs-domain/commit/99fbc0646c0a8cd1f79df9ae03a372d1eb2b00e7 in order to avoid "undefined" getting pushed to evtsToDispatch That happens when stream.eventsToDispatch is "undefined"; and stream.eventsToDispatch is "undefined" when you...

Having queue in nodejs' memory makes cqrs-saga not amenable for clustering

8

The fact that queue of events maintained in memory, made me suspect that this is not going to work in clustered environment. Ref.: https://github.com/adrai/node-cqrs-saga/blob/9770440df0e50b5a3897607a07e0252315b25edf/lib/orderQueue.js#L11 Some tests confirmed it. My test...

Redis SagaStore implementation bug: it creates multiple entries in redis for the same saga-id

4

I found this while I was trying the timeouted-saga feature; it keeps returning the first instance of the saga (that has no timeout, a.k.a.: keyed in redis as {prefix}:{createdtimestamp}:Infinity:{thesaga-id} ....

currentHandlingRevisions in revisionGuard never gets cleared. Possible memory leak.

5

https://github.com/adrai/node-cqrs-saga/blob/9770440df0e50b5a3897607a07e0252315b25edf/lib/revisionGuard.js#L51 This container (hash) currentHandlingRevisions never seems to get cleared at any point. I'm concerned about memory leak when I turn on the revisionGuard for my process manager. Is it...