Sander Kromwijk

TOC just wrong in random(?) ways

5

TOC positions seem to not be interpreted correctly, with an inconsistent error. Using the following code to generate a book: ``` $mobi = new MOBI(); $mobi_content = new MOBIFile(); $mobi_content->set("title",...

Vararg overloading method ordering

5

First of all, thanks for building JSweet! It's been a very pleasant experience this far. While using JSweet to transpile code generated by Immutables, it generates invalid code on varargs...

Currently the following sequence ends up in an approve: 1. Reviewer approves 2. Reviewer requests changes (e.g. because an issue was spotted later on) 3. PR author dismisses request changes...

Move all AtlasDB persisters to the new reusable type

5

## Before this PR Non-reusable persisters are created for each cell read/write. This causes a lot of object creation, which is particularly problematic when a new object mapper is created,...

Support record types

2

## What happened? When using record types, I hit the following issues: - Misfiring `StrictUnusedVariable`: ``` Foo.java:43: error: [StrictUnusedVariable] The parameter 'a' is never read. record Foo(int a, int b)...

## What happened? When using code of the shape `foo instance String myString`, both checkstyle & spotless fail. Checkstyle: ``` [ant:checkstyle] Foo.java:70:50: unexpected token: foo ``` Spotless: ``` ... Caused...

Add statistics to spans

3

**Goals (and why)**: Teams using AtlasDB can diagnose service-level statistics, but trace-level usage information needs to be reconstructed indirectly. This PR is the first step to create easy-to-digest statistics to...

Clarify double/lossiness handling

2

## What happened? Doubles in conjure-java failed for some numbers that should've been supported: https://github.com/palantir/conjure-java/pull/1006. While discussing the fix we realized we haven't defined how we expect conjure to handle...

[Discussion] Remove `type` field from union types

15

Conjure's union types can end up being extremely inefficient in terms of bytes in the wire format, for example when encoding ASTs (where there is generally a lot of polymorphic...

[Proposal] Encode constant values in conjure file

3

Even though all state encoding should go through the current type-able constructs, there are cases where a constant value becomes part of an API. This can happen when interacting with...