Rahul Savani

With regard to Ted's point 1: There are lots of examples of reference tests for `liap_value`, which is 0 if and only if the corresponding profile is a Nash equilibrium,...

> @rahulsavani Do you agree with my analysis, or again am I misunderstanding something? This sounds correct to me, and I like that we can just return the empty list...

We should add them as part of the changes for #617. Also, I note that none of the test instances for enumpure_solve "agent" currently have agent-form equilibria that are not...

Agreed, though if we already have the OpenSpiel one pretty-much ready we may want to have that one up sooner rather than later.

> In general what do we think about mentioning places where Gambit is available via packaging systems? Almost always these are done by people we have no contact with, so...

> Although the discussion went in a different direction, on further reflection, should we re-open this and deal with getting set up to authenticate the generated app for 16.5? [@edwardchalstrey1](https://github.com/edwardchalstrey1)...

The issue is with `ComputerPayoffs` in `MixedStrategyProfile::GetLiapValue()` of game.cc. For the "strategy" payoffs that populate `map_strategy_payoffs`, we call `GetPayoff(strategy)`, which in turn uses `GetPayoffDeriv`. In the case of starting with...

Thanks @edwardchalstrey1, ReviewNB indeed seems nice and convenient.

I clicked approve rather than changes requested, and can't see how to edit it now. I presume you'll make these changes or comment further.

> > Before we finally merge let's also squash the commits down to one or a smallish number. > > I think it does squash commit by default There are...