Rahul Kamat comments

Results 5 comments of


                                            Rahul Kamat

#3840 - allow user to pass any path separator as --chunk_output_path_prefix

Looks like the CLA bot still doesn't recognize you. Did you follow the steps in https://github.com/google/closure-compiler/pull/3988/checks?check_run_id=7995613406

Missed optimization: document.querySelector('') turns into var b=document;b.querySelector.call(b, '')

Thanks for the report

Update async-test.ts to use globalThis polyfill

@AndrewKushnir I missed your comment, I don't think we need to run a TGP internally. It looks like a test file, so I don't think anything other than the test...

`@pureOrBreakMyCode` can't handle when left-hand side is array pattern

This might be a problem with the compiler's [RemoveUnusedCode pass](https://github.com/google/closure-compiler/blob/master/src/com/google/javascript/jscomp/RemoveUnusedCode.java) If we can repro this with a unit test in [RemoveUnusedCodeTest.java](https://github.com/google/closure-compiler/blob/master/test/com/google/javascript/jscomp/RemoveUnusedCodeTest.java), we can confirm that `RemoveUnusedCode` is not supporting `/**...

`@pureOrBreakMyCode` can't handle when left-hand side is array pattern

I've spent some time looking into this, your latest example shows `complexPureFunction1` completely getting removed but `complexPureFunction2` is not removed by `RemoveUnusedCode` I also added these 2 examples as unit...