Rafał Cymerys comments

Results 40 comments of


                                            Rafał Cymerys

Pin sandbox to use correct branches

Resolved by https://github.com/spree/spree/pull/11741

Update Country field position at checkout for no USA countries in address.rb

@4goodapp looking at the overall structure of the updated form, wouldn't it also make sense to move zipcode after city?

Fixes #10971 - First two issues

Hi @singhdurgesh thank you for submitting the PR. Could you describe what's the reason behind doing a to_s conversion before converting a parameter to integer?

Fix typo in image resize params (gravity)

Hi @mrbrdo - this is coming from libvips, which is the default option for image processing in Rails 7. As far as I see, they use `centre` instead of `center`...

Fix typo in image resize params (gravity)

Closing, as this is covered in #11792 that has been merged

Update order after removing a line_item

This was already fixed in #11700

Extract API v1 into `spree_api_v1` gem

This is now done in https://github.com/spree/spree_api_v1 repo!

fix property filters to work with Postgres

Hi @mrbrdo - what was the problem with postgres here? I have my intuition, but would like to confirm if I'm reading it correctly ;)

fix property filters to work with Postgres

That makes sense. Was that an issue coming out of your customization (where the scope coming in had the order set) or an issue in core spree?

FriendlyId::Slug is not a reloadable class (like app/ files), so we s…

@mrbrdo we've just recently took over the maintenance of Spree, and I'm currently going through old PRs after stabilizing the testing/build process. This one will most likely be merged in...