radhika reddy

Results 27 comments of radhika reddy

There seems to be two issues under discussion here. One is about avoiding the Leiningen implicit hooks warning (but keeping the brittle `.lein-env` file strategy). The other is about finding...

So there are 3 aspects to this bug. 1. The text-field component isn't detected by Reagent as an input component. (The `input-component?` patch solves this.) 2. When there are updates,...

@madvas Reagent master has `b65afde4` which uses `find-dom-node`. Not sure if targeting `0.6.0` without `find-dom-node` will be buggy. Nevertheless, something like this might work: ``` diff --git a/src/reagent/impl/template.cljs b/src/reagent/impl/template.cljs index...

Be careful with `set!` — I think it doesn't update all references to the function from callers in closures that were already defined (as the old version of the bound...

@madvas Try this, paste and invoke `set-overrides!`: ``` clj ;; A better but idiosyncratic way for reagent to locate the real ;; input element of a component. It may be...

@madvas I agree, this snippet is just a rough proof of the bug. I don't think cljs-react-material-ui should patch Reagent. But I also don't think Reagent should be specifically aware...

Quick update: still working on a more correct solution. My earlier snippet does update `` element values, but then input state does not always match the `TextField` component's `state`. In...

Nope, only got as far as a very specific monkey-patch that suits the application I'm working on, which would probably break Reagent for non-crmui users if factored out. Haven't made...

FYI something else I was looking at last time: maybe we can reshape the component being exposed to Reagent so that its `` is findable by the existing code that...

As a sidenote, leiningen 2.4 begins to deal with a similar problem, which supposes a general solution for project map processing that might apply to lein-npm. The newly introduced 'release'...