Roberto Cortez

Results 374 comments of Roberto Cortez

I've been focusing on other stuff. Let me see if I can free up some cycles to move forward with this. I don't remember exactly, but I think I've did...

Cool. I'll see if I can spare som free cycles to move forward. Cheers.

> Can you describe what your use case for needing to be able to select a span processor other than the batch span processor? The simple span processor isn't really...

Yes, I was aware of that. It does work. I just find it a little bit weird to use this magic name in a custom `SpanExporter` :) BTW, another workaround...

To make it clear, the idea was not to select the `SpanProcessor` to use as suggested in https://github.com/open-telemetry/opentelemetry-specification/pull/2172, but to be able to influence in which `SpanProcessor` a `SpanExporter` will...

> @radcortez can you please add a test? Tests already exist: - io.quarkus.opentelemetry.deployment.NonAppEndpointsDisabledTest - io.quarkus.opentelemetry.deployment.NonAppEndpointsDisabledWithRootPathTest - io.quarkus.opentelemetry.deployment.NonAppEndpointsEnabledTest - io.quarkus.opentelemetry.deployment.NonAppEndpointsEqualRootPath This changes the underlying implementation to use the `http.target` to match...

> It's just because this behaviour seems not to be considered in the current tests... Something that will break if `http.target` usage is reverted. What do you mean? The old...

> The actual getting of the Config object happens in `org.eclipse.microprofile.config.spi.ConfigProviderresolver` though, so that might make it harder to fix as it's outside of Quarkus Then I guess that it...