André Carneiro comments

Results 11 comments of


                                            André Carneiro

networks remove() issue

This issue is still happening, i was going to create a PR but @randydu bug fix is perfect. Can i open this PR?

[Design] Automatically lock wallet due to inactivity

I like the design, but what are the downsides of using a simpler `setTimeout` to lock and any interaction just re-schedules the timeout? This would eliminate the need for a...

[Design] Automatically lock wallet due to inactivity

> But why we do not have a passphrase in this case? There are any material I can read about this decision? It is not a decision on our part,...

[Design] Automatically lock wallet due to inactivity

✅ Approved.

Upgrading to `react-scripts@5`

We need the nodejs libs mostly for the wallet-lib, but this can change if the lib builds for browsers. I think a good idea would be configuring the lib to...

[Design] Atomic Swap user interface

LGTM

[Design] New encryption standard

reviewers: @pedroferreira1 @msbrogli

[Design] New encryption standard

> I didn't understand this. This migration will happen after the user upgrades his wallet. Versions before v0.26.0 are the ones without the new storage scheme, then we can migrate...

[Design] New encryption standard

> The checkPassword and decryptData have duplicated code. For the final version we must improve this. Done

Error: undefined caused by opening multiple notebooks simultaneously

Maybe python fcntl module may help This example makes a non-blocking attempt to lock a file, but if only LOCK_EX was used, it would wait until he gets the lock...