Roland Oldenburg
Roland Oldenburg
Patch file cannot be attached, so I post it here: ``` From 5e28dd9030b4962245e938c39c133de32af1e592 Mon Sep 17 00:00:00 2001 From: Roland Oldenburg Date: Wed, 21 Jul 2021 13:58:12 +0200 Subject: [PATCH]...
@garris Wow. That is a prompt reaction! You maybe want to consider adding a switch to the config, allowing to pass in `captureBeyondViewport`. Or maybe even better add the possibility...
@garris _Maybe just for selectorExpansion=true type of sceenshots?_ Possible, of course. But I am not sure if this really only happens in the `selectorExpansion=true` case. And vice versa I am...
_captureBeyondViewport=false I guess could cause regressions if someone is trying to capture a whole document_ Maybe, yes... Sorry, I should have mentioned my concerns from the beginning.
Thanks also for this great tool!!!
Still I would propose a switch or a config object to be optionally passed in. So that users can have a way out if they encounter regression.
Could this be related to https://github.com/garris/BackstopJS/issues/1344?
Hi there. Same here. Updating to higher than 4.4.x makes a big part of our tests fail due to cropped images. Even with 5.0.6 and `"puppeteerOffscreenCaptureFix": true/false` and `"useBoundingBoxViewportForSelectors": true/false`...
Somehow this seems to be gone with 5.3.4... Can anybody else confirm?
Interestingly it is said there that it may be "something that might already be addressed"... Maybe we are lucky..?!