Ryan Murphy

Results 5 comments of Ryan Murphy

I took a shot at solving this. It's my first time developing on an extension so I'm not sure what's possible exactly. I added to the existing script insert condition....

I'm willing to implement this. I was wondering if it could be included in `always-return`. I had it working on an older version of `always-return` but then it got refactored....

I redid my implementation with the refactored always-return. You can have a look on my fork. No doc updates yet. I'll wait to hear back on what you think of...

@HyperBrain Yes, I agree. And that's why my change was checking for. Are you seeing different behaviour?

@HyperBrain Those error cases are covered in my unit tests. Here's the commit diff. https://github.com/r-murphy/eslint-plugin-promise/commit/370330101e64261e2637ca861e64911c772ef2a3 My commit was from 2016 so it probably won't even merge in anymore anyways.