Quentin H

Results 10 comments of Quentin H

I try to resolve these issues by adding a call to the `changeLanguage` function of [buttercup/ui](https://github.com/buttercup/ui), but there is an error in the build. Does anyone know how to resolve...

Hi guys, it's a wonderful idea

After reviewing the code, it seems that triggering the event on every configuration save might need some optimization. Instead of calling the `onLanguageChanged()` event with every preference save, could we...

Hi @rahuldkjain, Could you please merge this PR? If you need assistance, I'm available to review more PRs. Thanks!

I have started looking into this bug. I can reproduce it, but I don't yet understand where it comes from. I suspect the core is returning changes that do not...

@perry-mitchell I added a test ([https://github.com/buttercup/buttercup-core/commit/f6231fad295dd3e7d3d2d2f04d773e7a56f189d6](https://github.com/buttercup/buttercup-core/commit/f6231fad295dd3e7d3d2d2f04d773e7a56f189d6)), but it works and does not reproduce the bug. Do you have any ideas?

@perry-mitchell I think I know the source of the problem, but I don't understand where it occurs in the core. Indeed, in the desktop version, after creating an attribute, any...

Hey everyone, Sorry for pausing my work on this issue for a few months, but I'm back now. I have added some tests in the core: [compare changes](https://github.com/buttercup/buttercup-core/compare/master...quintushr:buttercup-core:master). However, I...

@perry-mitchell, I have a question regarding the handling of attribute changes in `VaultFormatA.ts` and `VaultFormatB.ts`. It seems that attribute changes are excluded, which might be causing our problem. Currently, only...

Sorry to bother you, but I wanted to know how I could test the core with the desktop to see if my changes fix the problem. Thank you in advance...