Ashi Krishnan

insert definitions and @link headers for fed2 schemas

2

reinstate #1554 using `_FieldSet` rather than `federation__FieldSet` for fedv1 schemas

Make CustomEntitySerializer public

1

Could we make this trait public? It would be nice to implement it to control entity keys without worrying about the rest of serialization.

use the system keychain to store sensitive profile data?

1

## Description should we store sensitive profile data in the system keychain? there's [a crate](https://crates.io/crates/keyring) for it. arguments for: - it's what [apple](https://developer.apple.com/documentation/security/keychain_services/keychain_items/using_the_keychain_to_manage_user_secrets) and [microsoft](https://docs.microsoft.com/en-us/windows/uwp/security/intro-to-secure-windows-app-development) recommend - it keeps the...

Overlap with tagged template literals / Number prototype properties

1

We already have template literals and an extensible `Number.prototype`. The value prop here seems a bit low for a syntactic change. This works today: ```js const unit = name =>...

Specifically, throw if grammar builder functions are passed wrong number of args. This catches the common (for me) problem of doing something like `optional('+', $.term)` when I meant to do...

Interpret arrays as sequences and implicitly sequence multiple rules

2

This PR is purely ergonomic. I find that I keep doing things like this: ```js optional(',', $.decimal_digits) ``` (instead of ```js optional(seq(',', $.decimal_digits)) ``` ) My time-of-confusion is dropping, but...

Describe your PR here

Hi, here's a description.