Li-Huai (Allan) Lin
Li-Huai (Allan) Lin
The one more label you pointed out is ``, which exists by default when you instantiate LabelEncoder. https://github.com/PetrochukM/PyTorch-NLP/blob/d7814a297811c9b0dfb285fe0475098b86f3d348/torchnlp/encoders/label_encoder.py#L7
> Does this issue need handling? Hmm..It's somewhat confusing indeed, maybe we can add proper notes or comments in the documentation to make it clear.
Kindly explore opened issues and find something in which you are interested to contribute :-)
Fixed in #139 .
Fixed.
> I think one reason why mxnet 1.0 failed is that we don't care others and give no reply to their questions in discuss.mxnet.io . @StevenJokes Thank you for mentioning...
@szha I was in the dev mailing list months ago, and I’m not really a new. BUT what @StevenJokes said really make sense, it is the most important thing, even...
@pytorchbot rebase
Could you rebase and see if the failures are gone?
@TachikakaMin Hi, would you mind updating this PR per the review comments so that we can get it merged? Or if you don't mind, I can update it myself when...