Vadym Tishchenko comments

Results 7 comments of


                                            Vadym Tishchenko

Remove unreachable code

Maybe better to add try/finally to show how to handle close event? What you think? Something like ```python try: while True: data = 'Server Time : {}'.format(datetime.now()) print(data) await resp.send(data)...

Remove unreachable code

There is opportunity to handle it. For my project it was very useful, but not so obvious

Remove unreachable code

Oh, I blind, sry :(

Echo response object calls flush on unflushable objects

I agree that it's supposed to cause panic if flushing is not supported, but at least, it should have a chance to unwrap parent writers to check if there is...

Echo response object calls flush on unflushable objects

About timeout middleware, I don't fully understand you, It does just what I want it to do - cancel context, if timeout is reached

Echo response object calls flush on unflushable objects

It seems that you are right. I'll recheck what behaviour exactly I need. Thanks!

How to run SetupTest in table tests using test suite?

I think it can be closed after release https://github.com/stretchr/testify/pull/1246