Peter Harrington
Peter Harrington
Addressed by https://github.com/NVIDIA/physicsnemo/pull/845
@daviddpruitt has this been covered by #879?
I added some minor suggestions, overall this looks great though. I found the LambdaLR scheme with the custom hydra resolver a bit convoluted, maybe a ConstantLR would be simpler and...
I think all my main comments are in. Aside from minor things, I think the main thing to focus on is how much the additional SFM stuff can be absorbed...
Hello, Thanks for raising this issue. It is still on our roadmap to provide more complete dataset preparation instructions for this example, but at the moment I can't give you...
Hi @running-berry, thanks for highlighting this issue. The README has a typo, the correct file that specifies the base dataset class is actually`datasets/dataset.py`. We will update this. @jleinonen for viz