Philipp Zerelles

> How would you have `/[locale?]/[...slug]` match? That seems to fall into the same problem as `/[...locale]/[...slug]`. Without a matcher, you are right. So maybe the way the matcher is...

Looking at the source code, this is not easy because the route's regex match takes place before the matchers are called in `exec`. Maybe an optional regex defined with the...

There is so much boilerplate to write, even more if you need backward compatibility with WebP in a picture tag. But since svelte is a compiler, can't we just have...

I wrote a little preprocessor to make using vite-imagetools even easier. Modifiers can be directly appended to the img's src or srcset prop and the imports will be added by...

Yes, I forgot that 🙈Am 2023. 12. 12. um 18:49 schrieb Ben McCann ***@***.***>: @benmccann commented on this pull request. In packages/vite/src/node/plugins/importAnalysis.ts: > @@ -401,7 +401,8 @@ export function importAnalysisPlugin(config:...

You mean the line in `packages/vite/src/node/plugins/importAnalysis.ts`? That's the only line I was not 100% sure, but without the change it throws for some URLs. There is a `decodeURI` somewhere that...

Thanks so much for providing the right location. I probably didn't understand the code good enough. The original problem is also fixed when moving the encode to that location.

Yes. There is also another thing. Right now I encode only placeholders `__VITE_ASSET_{id}__` and not `__VITE_PUBLIC_ASSET_{id}__`, because I found no documentation about it and when it is used.

Instead of adding a new test I extended the existing unicode url test to include a % character. That test was wrong before anyway because in dev mode it expected...

> @pzerelles we discussed about this in today's team meeting and decided to move forward with the change, but using a helper for performance reasons that will only transform `%`...