Clinton

@gerrrg Automated _unit_ tests can be implemented by stubbing out external behaviors using pytest. I think it would be of value to test the internal logic of this library, not...

Consider using Python's logging library to distinguish between INFO and DEBUG logging instead—this would allow developers to determine which log level is appropriate for their needs, it would also allow...

@felixxm I appreciate the feedback. Is there anything else that needs to be done on my part?

There do not seem to be existing tests that specifically test the functionality of `mixins.startup.serve`, nor the `startup` module overall.

Type error being raised by CI by line 724 of `mixins.startup` existed prior to my changes. https://github.com/sanic-org/sanic/actions/runs/10174510874/job/28140377393?pr=2992#step:2:566 Same for the 8 other mypy type-check errors.

This error is also raised when one attempts to close an already closed connection. Re-establishing a connection, in this case, would be undesired behavior. This is likely also a feature...

Possibly related to: [8.1->8.0](https://github.com/pytest-dev/pytest/compare/8.1.x...8.2.0#diff-e02b5aa2806cf9086c18c4d38b880df457d9313bf02ba108d58e67336abbab66R96) Changes to import resolution logic: https://github.com/pytest-dev/pytest/issues/11475 Bug fix related to importlib: https://github.com/pytest-dev/pytest/pull/12208

Is there a reason *not* to deprecate `skipIf` string evaluation, and just constrain the condition parameter to being type `bool`? Furthermore, would it make sense to deprecate `skipIf` all together,...

Yes to the soft deprecation. I should have clarified in regards to the deprecation—I meant adding a deprecation warning—at least until next major release. As for the lambda, It's still...

I was wondering if there was a use case for lazy evaluation—seems like there is.