Piotr Wójcik

`is_bootstrap_connection` should be const so it can't modify the state, but this issue will be fixed by https://github.com/nanocurrency/nano-node/pull/3861

Thanks for bringing attention to this issue, added a guard assert in https://github.com/nanocurrency/nano-node/pull/3863

With the upcoming upgrade to C++20 this feature could be implemented using the new `ranges` library, it provides all the necessary tools for sorting, filtering and pagination without the need...

I wouldn't worry about making a dedicated wrapper for each store, we need to have the results in memory anyway for sorting and serialization. Simply creating a `std::vector { store.begin(key),...

And if you want to adapt an existing store to work with ranges, maybe using the standard subrange class will do, like this `auto view = std::ranges::subrange(store.begin(key), store.end())`

Using the `std::ranges::subrange` should have the same behavior as your adapter class without writing any new code, I haven't tested it, but looking at the documentation it generates an adapter...

Is this an actual issue? Looks like the intended behaviour, since both caches are for the same build type one needs to be discarded and one stored.

In one of the recent runs, both caches were discarded for some reason, it's definitely a problem if that happens. https://github.com/nanocurrency/nano-node/actions/runs/4720247737/jobs/8372055401

I don't think the error message is accurate in this case, since both actions were not running concurrently in a run I linked. There is more info in a discussion...

Posting @gr0vity-dev test results here for reference ("heuristic" run refers to this PR): > I did a comparison for these, each time on a 10 node network with default votes/msg...