Phillip Whelan

Results 88 comments of Phillip Whelan

> Adding $this->runtime['Scheduler']['type'] = 'scheduler'; is useless, since it's never used. There is actually a few conditional checks for it a few lines down. https://github.com/pwhelan/Fresque/blob/0b01b685ef66c6daefaa5d2f07fe8b30fd101c91/lib/Fresque.php ``` if ($this->runtime['Scheduler']['enabled']) { if...

The patch fixed this issue: ``` [root@localhost click4time.new]# ./vendor/bin/fresque load -c fresque.ini -------------------------- Loading predefined workers -------------------------- Loading 6 workers Starting worker ...... Done Starting worker ...... Done Starting worker...

any chance this will ever get fixed? is there an unknown major change that will fix this implicitly? I know you don't personally use fresque so I am willing to...

I just tested it and it only seems to happen when the scheduler is enabled and when invoking `fresque load` but not `fresque startScheduler`.

Any chance of getting this merged? This is quite a show stopper for me.

I got this error running with 1.3.0 ``` PHP Notice: Undefined index: Scheduler in /var/www/html/dev1/click4time.current/vendor/fresque/fresque/lib/Fresque.php on line 445 Scheduler Worker is not enabled ``` The last line was in red....

``` [root@localhost www]# ./vendor/bin/fresque load -c fresque.ini -------------------------- Loading predefined workers -------------------------- Loading 8 workers Starting worker ... Done Starting worker ... Done Starting worker ... Done Starting worker ......

> Adding $this->runtime['Scheduler']['type'] = 'scheduler'; is useless, since it's never used. The very same member of that array gets used in a conditional not more than 3 lines down.

> Functions doesnt work without parentheses? =/ any plans of fixing this?