Pedram
> as long as the tests pass, I'm good with this. Thanks, PV Yeah had an issue with the E2E's but think it was just a time-out so we should...
Minimum required node version is 12.20, we are 12.18.4
Holding off until Simorgh upgrade to Node 16
Updating the `arabic.json` fixture and running just the `amp` tests doesn't result in any snapshot failures but 128 skips? The `canonical` tests however, had 2 fails. One for the curations...
Running verbosely, it seems all the tests relating to `src/integration/pages/homePage/arabic/canonical.test.js` are being skipped
After a bit of investigation I think this could be the culprit? Removing the `.only` from here: https://github.com/bbc/simorgh/blob/integration-test-investigation/src/integration/common/ads.canonical.js#L21 Returns: When no `.only` is applied to same tests when we were...
Also no longer getting that `localStorage` error when that `.only` is removed when I re-run the script:
Re-running the E2E's on this but Cypress just got patched this morning: https://github.com/bbc/simorgh/pull/11605 And i'm not sure if the failure is related, just FYI.
Hey hey, I know this is temporary solution but just to highlight (if I'm understanding correctly) `useImageColour` now runs for every `Image` instance before checking `isPromo`/`isPortraitImage` according to the Image...