Tim Fox
Tim Fox
@severb assigning this to you. I don't have an M1 so this is hard for me to reproduce.
> Will adding DOCKER_DEFAULT_PLATFORM=linux/amd64 make start to [Docker-based demo doc](https://github.com/cashapp/pranadb/blob/main/docs/demo_docker_compose.md) be sufficient to close this issue? We need someone who has an M1 laptop to verify that. If it works,...
Yes a similar check
Need to verify if this is the case
Hi @mohsalsaleem instead of duplicating the code in checkConstantShards, I think it would be better to abstract out the common logic and use that. E.g. create methods, getConfigProperty and setConfigProperty
No worries :) In the mean-time can you make sure you have signed the CLA, if you haven't done so already. https://docs.google.com/forms/d/e/1FAIpQLSeRVQ35-gq2vdSxD1kdh7CJwRdjmUA0EZ9gRXaWYoUeKPZEQQ/viewform?formkey=dDViT2xzUHAwRkI3X3k5Z0lQM091OGc6MQ&ndplr=1
Yes, just add a test in dragon_integration_test.go which tests your new methods. You don't need to change the Dragon struct as the test already passes the replication factor in.
Hi @mohsalsaleem just checking in to see how things are going? :)
I think it's OK to export it
Hi. Just checking in. Are you still working on this? If not, we can reassign to another team member.