Pubudu Fernando

Results 16 comments of Pubudu Fernando

Can't we get this merged?

Let's close this and reopen/resend when looking into this again

+1 for adding a public API for this. Currently there's no way to compare identifiers when it's a mix of escaped and unescaped identifiers.

> @dulajdilshan is `getName()` returning `'version`, the expected behavior? Don't we expose both the original value and the unescaped value? if we expose unescaped value don't we remove the quote?...

> Yes. We should not expose internal encoding/decoding methods as apis. Lets expose unescape method only in Identifier-utils module as a separate api package method. Need a method for escaping...

+1 for this. Any idea on when this will be available?

@mattgogerly I'd like to give this a try. I had a look around and guessing the API docs are getting generated by the build tool at https://github.com/spinnaker/buildtool right? I tried...

> @pubudu91 Any update on this? Sorry, missed this. IIRC, I tried this with 2201.2.x as Asma suggested and didn't come across this issue. Hence closing this.

In the previous config API, configs were considered from multiple sources. So whether the configs were defined in a file or as env vars, they could be looked up through...

> Compiler plugins (analyzers) enforce constraints on packages. Here are some sample constraints: > > * No service declarations are allowed > * No Listeners are allowed > * All...