Paulo Neves comments

Results 35 comments of


                                            Paulo Neves

Filling password from manager in private browsing requires many steps

It is 2022 and it is still not fixed. A privacy feature no less.

DATA RACE: Disconnect()

It seems this can happen without incorrect library usage if there is a reconnection. Specifically, I try to call Disconnect() when behind the scenes a reconnection happened. ``` WARNING: DATA...

DATA RACE: Disconnect()

Ok i had a look that the code and it is very tricky. We have a mutex(connMu) protecting concurrent writing `c.commsStopped = make(chan struct{})` but we do nothing about reading...

DATA RACE: Disconnect()

Thank you for your fast and thorough answer > This is not ideal but given how rare this set of circumstances is may be the best option? We will try...

DATA RACE: Disconnect()

The error is always reproducible if running `go test -race -run Test_autoreconnect -v`

DATA RACE: Disconnect()

After understanding the code better and specifically the Disconnect() method I find that just removing the following line fixes the issue without any real adverse effects: ``` case

@MattBrittan Thank you. Honestly, I have a [big refactoring and fat-cutting patch privately](https://github.com/ptsneves/paho.mqtt.golang/tree/dev-wip), but this issue does not seem solvable without ugly synchronization primitives for the commsStopped channel.

Paulo Neves

Filling password from manager in private browsing requires many steps

DATA RACE: Disconnect()

DATA RACE: Disconnect()

DATA RACE: Disconnect()

DATA RACE: Disconnect()

DATA RACE: Disconnect()

DATA RACE: Disconnect()

core: event: add mk_event_channel_destroy function for mk_event_chanel_create.

Unique id

Use monotonic clock when possible