Pascal Tomecek

> Is there any reasonable workaround for this, perhaps by overwriting `__get_pydantic_core_schema__`? I made a naive attempt to copy what `SerializeAsAny` does: > > ```python > class MyModel(BaseModel): > @classmethod...

I originally was also not a fan of the way that algos communicated with each other (especially the fact that you need knowledge of the magic strings that correspond to...

@jangorecki @maartenbreddels Looks like #150 is closed, was there ever a PR to include Vax in the benchmarks? I don't see it in the latest generated report.

I also wonder if we shouldn't adopt or take inspiration from some of the other libraries out there that define numpy types. In particular: - https://github.com/patrick-kidger/jaxtyping - https://github.com/ramonhagenaars/nptyping - https://github.com/caniko/pydantic-numpy

@robambalu Latest commit should incorporate all your feedback

@AdamGlustein All your other feedback is incorporated, but I would also love an answer to the units question, so leaving that one open for now.

> `EasySeedLinkAdapter` is pretty useless on its own, i would combine with `EasySeedLinkAdapterImpl` as [here](https://github.com/Point72/csp/blob/60e447340ef8897838e8a5fae3a1615fd9572345/examples/04_writing_adapters/e7_adaptermanager_inputoutput.py#L35). > > Also `EasySeedLinkAdapterImpl` / `_EasySeedLinkAdapterImpl` , `EasySeedLinkAdapter` / `_EasySeedLinkAdapter` is pretty awful naming unless...

@timkpaine I've updated the adapter definition - agree it's much more straightforward now. @AdamGlustein I've added a link to the USGS FAQ on seismography that has more background information about...

> * [ ] Needs tests > * [ ] `README.md` in `07_end_to_end` similar to [this](https://github.com/Point72/csp/blob/827558828e572ce1ae8a7c91de262652e79fa022/examples/06_advanced/README.md) > * [ ] Outputs stripped (meh) or notebook stored in LFS (also meh)...

> * [ ] Needs tests > * [ ] `README.md` in `07_end_to_end` similar to [this](https://github.com/Point72/csp/blob/827558828e572ce1ae8a7c91de262652e79fa022/examples/06_advanced/README.md) > * [ ] Outputs stripped (meh) or notebook stored in LFS (also meh)...