Jiri Hörner comments

Results 6 comments of


                                            Jiri Hörner

Double precision for Data3D

I agree the way `pointRangeScaledInteger` is used is very confusing. We could simplify the API by removing the option to write scaled integer data and support only float and double....

Double precision for Data3D

Thanks for looking into that!

UTF-8 File Name test failure on Windows

I think the problem is probably handling of the string literal by MSVC. Are you setting `/utf-8` when building the test? That should fix handling of string literals by MSVC....

UTF-8 File Name test failure on Windows

I have checked the code and the actual handling of path name should be correct as far as I can see in both win and posix paths.

UTF-8 File Name test failure on Windows

I think it is better to use them directly. One just need to make sure that: 1. Files are UTF-8 encoded 2. `/utf-8` is set for MSVC Then it works...

Simple API implementation of E57_EXT_surface_normals doesn't handle scaled ints

I'm not sure whether there is any real need to have normals in doubles. Normals should be of unit length and float has more than enough precision within [-1, 1]...