Petar Tasev

I noticed a bug with the MorphTargetBuilder. https://github.com/vpenades/SharpGLTF/blob/f34511e1d656c006fa2b68311ed0c4b5de6dbf1b/src/SharpGLTF.Toolkit/Geometry/MorphTargetBuilder.cs#L88-L103 On Line 90, it checks for geometry to be default, but this is bad in the case that material is not default....

I was trying to create a unit test for a potential bug, but I ran into a different exception with accessors in my code. Do you see an issue with...

Thanks, I'll add the test soon. It seems the test passes now, but if I add the following lines at the end then it fails: ```csharp AttachmentInfo .From("ColorMorphingMultiPrim.glb") .WriteFile(f =>...

The validator definitely complains that there needs to be the same number of morph targets in every primitive. This makes sense since the weights array is the same across the...

Here's what I could find in the spec:  So I guess we can make the array with a bunch of empty objects and make sure it's the same number...

That I'm not sure of, but if the first part I highlighted is correct, then that means we don't need to include all attributes specified by the base mesh, and...

That's contrary to their spec. I posted a comment on the issue in the gltf repo, so let's see what they say.

Not sure if you saw this on Discord, but currently there's no way to get `IMaterialTransform` from `DrawableInstance`.

Looks like if the morph target doesn't have position deltas, then calculating smooth normals fails (line 87). The position deltas is null. Even if I put a check for null...

Part of what makes the library so useful is a lot of helper classes on top of glTF to help work with the data. I think this is a good...