Pyush Sinha

Results 20 comments of Pyush Sinha

I would love to implement this and plan to open a PR soon. Since this is a pretty core feature, I'm writing this comment in case an external PR like...

Since this discussion is still hot I'm going to plug my PR and implementation outline again #5345 to see if I can get some community support ty The 1st PR...

> > A "plan mode" is different from a "planning prompt" because it allows you to send multiple requests having the peace of mind that you are still in plan...

> > Ok, maybe the answer to this, and to make everyone happy, is to have a feature that GitHub Copilot already has: custom chat modes. That way, users can...

> If this feature request is reviewed and approved, I'd be happy to personally work on the implementation and submit a Pull Request for it. I'm ready to contribute to...

For anyone looking into these issues, perhaps some of these issues have been resolved by #3727 but were filed before it was merged. Checking if issues can still be reproduced...

Maybe #4669 is related and should be linked not sure

The PR successfully refactors `SettingsDialog.tsx` to use `useReducer` and `useInlineEdit`, significantly improving state management and readability. I have reviewed the code and tests, and here are my findings. ## Code...

> ## Logic Issue (Reset to Default) > I confirmed the potential issue with resetting to default values for **restart-required settings**: > > * The `PendingValue` type in `settingsDialogReducer.ts` is...

Thanks for the significant refactor! This cleans up the state management in `SettingsDialog` and aligns well with our React guidelines. I've reviewed the changes and the discussion. Here are the...