Pat Sharkey
Pat Sharkey
@zeitounator I'm going to try and eliminate the duplication. Now that there's a molecule scenario in place for docker as well it will be easier to iterate on this problem....
@zeitounator This should be ready for review now when you get a chance.
@zeitounator No worries. In the meantime if anyone wants to use this and #173 they can use [ansible-galaxy install -r requirements.yml](https://docs.ansible.com/ansible/latest/reference_appendices/galaxy.html#installing-multiple-roles-from-a-file) with a `requirements.yml` file like: ```yaml --- # Install...
https://github.com/snyk/leaky-vessels-static-detector/blob/main/gh_crawler/README.md?plain=1#L8-L9 says these are optional but https://github.com/snyk/leaky-vessels-static-detector/blob/main/gh_crawler/src/collect_dockerfiles.sh#L22 requires them? https://github.com/snyk/leaky-vessels-static-detector/blob/main/gh_crawler/README.md?plain=1#L22-L25 - the image names `static-scanner` and `static-detector` are not consistent.
Also, the [--dockerhub](https://github.com/snyk/leaky-vessels-static-detector/blob/5e2f9a375750c9b13cf47ff393a99da8f5f6bfd0/gh_crawler/src/scan_dockerfiles.sh#L34) flag causes - ``` time="2024-02-05T16:01:49Z" level=info msg="[ + ] Running Leaky Vessels Static Detector" flag provided but not defined: -dockerhub Usage of dockerfile: -base Run analysis on...