Michael

Results 7 comments of Michael

https://github.com/schreibfaul1/ESP32-audioI2S/issues/652#issuecomment-1882291425

Sure! Is it ok if I also make addRGB565Line tail call into addLine to deduplicate the code?

Lets just go with checking for spaces, it doesn't really matter if it's a valid IRC nick. This is copied from how attacks.py validates.

Its not about that, its about it blocking valid irc nicks for example with the ` character

ok i tried making it link against the libgcc.a in the repo and the binaries match except an extra instruction needed to setup the stack pointer due to bigger sram.

No, I think you need to add `LDFLAGS+=-L$(CH32FUN)/../misc -lgcc` to the v00x block, assuming you think it’s right to use the vendored one for v00x (I don’t know the consequences...