arty comments

Results 7 comments of


                                            arty

endOfInput error when calling ListObjects against localstack/moto mock of S3 service

I investigated this thoroughly. The problem is that the ListObjectsResponse contains Delimiter which is Char type and so it's expecting either the field to be absent or to contain precisely...

[draft] [opinions welcome] Change the individual callback functions in run_program to a trait which simplifies lifetime management

thanks @Rigidity for the typedef suggestion and catching the ungated declaration.

Cache derivations in pytest runs, saving about 12% of test runtime

A small comment i have is that at block_tools.py line 303, it'd be nice to name the members even if just for some future person. At line 202, how would...

Cache derivations in pytest runs, saving about 12% of test runtime

Definitely in favor of this pr. Apologies for letting the review process get old.

pass in allocator to post-eval callback

ok on balance this move on its own is ok.

Compiler fails sometimes when parameter deconstruction not used

thanks i have a candidate fix for this fairly certain it's a stray bug introduced in the conversion to rust pr: https://github.com/Chia-Network/clvm_tools_rs/pull/65

Ak.update typescript

if you merge the main change from before, that should fix the clippy issue here