Bryce Neal
Bryce Neal
I have left an API suggestion in another issue which would tangentially solve this problem. Let me know what you think. https://github.com/express-validator/express-validator/issues/527#issuecomment-401208952
@gustavohenke Any recommendations on how to gracefully test this? I have a couple of tests, but ideally we run all of the same tests that touch the exports of `index`...
For anyone else who lands here, it looks like jest supports data-driven tests natively now. http://jestjs.io/docs/en/api#testeachtable-name-fn
Hey Chnapy. I think it's a good idea. This library was written before Promises were standardized in JavaScript. Introducing native promises would be a breaking change. So I think it...
It is! There are a lot of improvements we'd like to make and not all of these are reflected within the Issues. I'll share a recent comment I left in...
Well if you're interested in contributing your improvements back here then I would certainly welcome it, but if you decide you want to take a different direction then you're of...
I like the idea of providing a custom function for something like this. You're jogging my memory of a past PR that started to do something similar, but I don't...
Ah nice catch. Mind opening a PR to fix?
Ah I see. Yes the directions themselves are a list of directions. We could make them a set. I think it's worthwhile.
This makes sense to me. Do you mind adding a new unit test which succeeds with this change, but would fail previously?