Preston Evans

Results 59 comments of Preston Evans

Hey @cmwaters, sorry I'm late to the party here. Regarding option 1, I see three pain points that we'll run into 1. Lack of domain separation: We would need to...

> What if we made it take `K: Into`? This is a good suggestion. I'll open a PR this afternoon. The underlying motivation for this item is to allow apps...

Hmm, on further thought I think this change will prevent `TreeReader` from being object safe

@zbuc Nothing immediate. I'll be trying to add `no_std` support this weekend, but the diff should be minimal and will just need review. I don't think we have any AIs...

Makes sense. I just tested with `v0.31.1` and the issue is still present.

@thanethomson It looks like `tendermint::block::Id` is the culprit here. You can easily reproduce the failure using the same `HEADER_JSON` as above: ```rust #[test] fn test_tm_block_id_serde_roundtrip() { let header: tendermint::block::Header =...

> I think the serde trait impls on all of those types are designed for serializing/deserializing JSON, not arbitrary other formats. Yeah, that seems to be the case. I know...

Will try to put up a PR to fix the documentation and close this issue later. @thanethomson @romac, any thoughts on where the most appropriate place for that documentation would...

@tarcieri TBC my use case is currently workable without serde, so I'm fine with just documenting the lack of support and closing out the issue. That being said, there are...

Hey @zvolin! I took a quick look at this and it's looks like the root cause is that risc0's `from_slice` method delegates to an implementation over a `Read`er, so borrowing...