Pete Bentley
Pete Bentley
@big-guy possibly of interest to you as you recently fixed the arm-v8/aarch64 confusion in native builds?
Thanks! I kinda forgot about the docs changes, I'll get on that. And do you have any pointer to where I should be adding tests?
Thanks, I'll work through that! One corner case I forgot - if there are versions of Xcode in the wild old enough not to support the `-arch` probe args we...
I do apologise, kind of swamped with the day job recently. I will have time to look at this PR over the coming weekend but if it's easier for you...
Working on it but note that both the `supplies args` tests in `AbstractGccCompatibleToolChainTest.groovy` appear to be currently broken... I can randomly change the expectations in the `where:` clause and they...
Unit tests and docs updated. Do we need an integration test?
> do you think you'll have time to [...] look at the corner-case for older Xcode versions? Looks like the `-arch` flag has been around on MacOS since at least...
But maybe masks an underlying bug? Those values shouldn't be null at this point.
My reading of the code is that these are preconditions, hence the use of `!!` in Kotlin whereas in Java we would use something like `Objects.requireNotNull()`. Because if the preconditions...
Should be fixed in `org.conscrypt:conscrypt-android:2.5.3`, currently going through the publishing pipeline.