PRATIK MISHRA
PRATIK MISHRA
> What happens when someone tries to update tags? Is that possible? @Datron currently this is not supported , a different api will be needed also we need to have...
@mahatoankitkumar shouldn't it should show total number of keys at top , instead of number of keys in that page ?
**Validation for Context (write Apis) - below validations are missing** 1. **put ("") (create or update context)** -> validate does the request body contains malformed conditions(jsonlogic) and validate empty overrides...
**Validation for Default-Config key** 1. **create or update** -> all kinds of validation already present , question is do we need to validate overrides containing same key when we are...
**Validation for Dimension key** We dont have different api for create and update 1. **create or update** -> currently we dont have restriction on dimension name , should we validate...
**Validation for Experiment Apis** 1. **create** -> we are not validating override emptiness and experiment name emptiness 2. **update overrides** -> validation for empty override is not present 3. **ramp**...
**Validation for Function Apis** 1. **create** -> validate function name
For String type validation we can follow the below approach : Create Newtype , for example DimensionName(String), ExperimentName(String), FunctionName(String) Next, define fn new implementation for each types like ``` impl...
Update on the above Approach , its more clean we just have to define tryfrom Trait where we can add he data validation as needed: We can declare newtype as...
**Validation of Dimension and Default Config's schema** We have custom type where user can define types using json-schema, so we should remove the jsonschema validation for Default Config and for...