Prashant V

Proposal: Discourage taking an address of empty structs

2

2 different objects can have the same address in memory if they are empty structs (0 sized). The Go spec calls [this out](https://go.dev/ref/spec#Size_and_alignment_guarantees): > Two distinct zero-size variables may have...

Proposal: Avoid blocking sends to a channel without timeout

8

Semi-related to [Channel Size is One or None ](https://github.com/uber-go/guide/blob/master/style.md#channel-size-is-one-or-none) We've seen cases of deadlocks/unexpected blocking caused by blocking sends to a channel (example: [tchannel-go#528](https://github.com/uber/tchannel-go/pull/528)). It's generally much safer to use...

Using `reflect.FuncOf` leads to a provide log without much context

2

If we have helper functions that return `fx.Options`, it's not possible to skip callers for logging, so we can end up with something like: ``` fxtest.go:43: [Fx] PROVIDE tchannelfx.Configuration

fx.Invoke should error out if the invoked function returns non-error types

2

I was helping someone and noticed they used `fx.Invoke` instead of `fx.Provide`, and was wondering why something wasn't working (they were providing a value group, but their result was not...

Currently, the error messages from merging are not very helpful: ``` returned a non-nil error: couldn't merge YAML sources: can't merge a scalar into a mapping ``` It'd be nice...

Global way to ignore known leaks from a set of tests

1

Currently, every call to `goleak.Verify*` needs to specify any stacks to ignore. If there are known leaks which affect multiple packages, this results in duplication in each package specifying the...

Consider use of t.Cleanup in goleak

1

Within a test, the recommendation is to use `defer goleak.VerifyNone(t)`. However, this can't be used inside of a test helper. We may want to support `t.Cleanup`, possibly via a new...

We have a couple of `strings.Contains` checks , e.g., https://github.com/uber-go/goleak/blob/7380c5a9fa8403fe6eb6354ceacf0cccdc0c61aa/options.go#L142 We should parse the stack trace and filter on specific parts of the trace (E.g., only function name) rather than...

[proposal] Allow users to create package global metrics

1

A user currently can't create a package global metric like so: ```go package foo var totalRequests = root.NewCounter("total-requests") func myFunc() {} ``` I'm not sure whether this is a pattern...

Yab only supports a single default peer, which means we have to assume a default transport, as it's unlikely the same host:port will support multiple transports. If we had separate...