Prajon Shakya comments

Results 21 comments of


                                            Prajon Shakya

Observe the `DefaultVaryHeaders` when creating the cache key

If I understood the code correctly, the existing code `varyHeaders = serverResponse.Headers.Vary.Select(x => x).ToArray()` are always replacing either there is varyHeaders or not. DefaultVaryHeaders are not being used as it...

Observe the `DefaultVaryHeaders` when creating the cache key

> Let me review, thanks for raising again. I might have overlooked it. Any update on this @aliostad

Observe the `DefaultVaryHeaders` when creating the cache key

At least we can fix the bug that we know, hence created the[ PR](https://github.com/aliostad/CacheCow/pull/288), because it gives confidence to move ahead in use of this library further.

[BUG][CSHARP-NETCORE] OneOf generator for not nullable primitives generates invalid code.

@jafin : Your update do not work if `format: string` is not defined for e.g. below case: ``` type: array items: type: string ```

OpentelemetryCollector incompatibility

cc: @TRybakSUMO

Question: Can we send traceid or span info when encountered error ?

cc: @TRybakSUMO ?

[AspNetCoreInstrumentation] Incorrect value for `http.route` when using razor pages and invoking the root path

Any update on this issue ?

Can we filter out the not needed resource attributes ?

For e.g. for AWSResourceDetector: If I need only `account id` and `task arn` and not others. out of [these](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/tree/main/src/OpenTelemetry.ResourceDetectors.AWS#usage)

Can we filter out the not needed resource attributes ?

Oh ok. I have to consult with my team then. I am not sure if we can manipulate resource attributes at collector level.

Reconsider adding `netstandard2.0` support for OpenTelemetry.ResourceDetectors.AWS

@Kielek