Paulie Peña

CDK v1's CloudFrontWebDistribution [constructor prop aliasConfiguration](https://docs.aws.amazon.com/cdk/api/v1/docs/@aws-cdk_aws-cloudfront.CloudFrontWebDistribution.html#aliasconfigurationspan-classapi-icon-api-icon-deprecated-titlethis-api-element-is-deprecated-its-use-is-not-recommended%EF%B8%8Fspan) does not exist in CDK [v2's CloudFrontWebDistribution](https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_cloudfront.CloudFrontWebDistribution.html), so I don't think this [line of code](https://github.com/nideveloper/CDK-SPA-Deploy/blob/bb67fa99523e150774122e059d792f2f901f8c44/lib/spa-deploy/spa-deploy-construct.ts#L169) is going to work w/ CDK v2. UPDATE: even...

For some reason, [the code is explicitly just doing those two](https://github.com/nideveloper/CDK-SPA-Deploy/blob/7922ec4a769d099d4d9e4ae6ba67ae8079d3200c/lib/spa-deploy/spa-deploy-construct.ts#L205), so if that was just removed, then the default of the underlying [BucketDeployment.distributionPaths](https://docs.aws.amazon.com/cdk/api/latest/docs/@aws-cdk_aws-s3-deployment.BucketDeployment.html#distributionpaths) is this: > All files under...

It seems like a simple fix is to add `distributionPaths` to `interface SPADeployConfig`, so `createSiteWithCloudfront()` could optionally use that passed-in value instead of the hard-coded ``['/', `/${config.indexDoc}`]``, like this: ```diff...

Instead of having to call `createSiteWithCloudfront()` with a `certificateARN` and then having to call `r53.ARecord()`, it would be nice if `createSiteFromHostedZone()` first checked if `config.certificateARN` existed before it tried to...

The fix is just to also set `this._connectLock = false;` in the `if (this._closeCalled)` case of `_connect()`, i.e. after [line 378 in reconnecting-websocket.ts](https://github.com/pladaria/reconnecting-websocket/blob/05a2f7cb0e31f15dff5ff35ad53d07b1bec5e197/reconnecting-websocket.ts#L378), since the `return` on line 379 is...

Good catch! Yes, the early exit from `_connect()` in the `if (this._retryCount >= maxRetries)` block also needs to reset `this._connectLock = false`, just like the early exit in `if (this._closeCalled)`.

I've implemented this feature in PR #122. With those changes, you can call `dispatcher.update_context({'key': val}` to pass in context data. You will also need to add `context_arg='{NAME_OF_FUNC_ARG}'` to your `@dispatcher.add_method(...)`...

Just as @flound1129 [said back on 2017-11-22](https://github.com/pavlov99/json-rpc/issues/79#issue-276155748), we need access to a WebSocket connection ID as well as the JSON-RPC `id`. The reason we need it is that there's a...

see my comment here: https://github.com/pavlov99/json-rpc/issues/79#issuecomment-885146740

If that's what @pavlov99 prefers, I can do that. Maybe instead of `@d.add_method(context_arg="context")`, we could just have true/false, e.g. `@d.add_method(context_arg=True)`. Although, I don't understand how that helps with static analysis...