Povilas Versockas
Povilas Versockas
One question is with https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/141#issuecomment-1205657264 we want to add `k8s.deployment.uid`, for which we will need to go with option 2, basically discovering k8s replicasets and parsing replicaset owner information. Unless...
> > We need to evaluate how big is the overhead for option 2. Based on that we can either do not add `k8s.deployment.uid` or go with the option 2....
> > But the judgements above are all basic on logic, I think to ensure the judgements we should first implements option 2 and test it in some test environment...
> @povilasv thanks for starting working on the issue in https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/12957. Do you want me to assign it to you? > > Yes, please. I want to also add DaemonSet,...
I think all the issues are resolved / updated, would be grateful for another look :bow:
I was thinking of doing smoke tests as a seperate PR as this is already really big, but I can work on this :)
@kylehodgetts ``` apiVersion: gateway.kusk.io/v1alpha1 kind: API metadata: name: todo spec: fleet: name: kusk-gateway-envoy-fleet namespace: kusk-system spec: | openapi: 3.0.0 info: title: Todo-Backend API version: 1.0.0 x-kusk: hosts: [ "example.org", "example.com"]...
I was looking at Envoys cors filter and seems it supports OPTIONS by default. I.e. users get automatic options using [CORS](https://kubeshop.github.io/kusk-gateway/guides/cors/) extension. For example, for this API: ``` apiVersion: gateway.kusk.io/v1alpha1...
@aabedraba maybe you can elaborate what wasn't working or what needs to be implemented?
You are not providing the headers: It is an [OPTIONS](https://developer.mozilla.org/en-US/docs/Web/HTTP/Methods/OPTIONS) request, using three HTTP request headers: [Access-Control-Request-Method](https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Access-Control-Request-Method), [Access-Control-Request-Headers](https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Access-Control-Request-Headers), and the [Origin](https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Origin) header. Ref: https://developer.mozilla.org/en-US/docs/Glossary/Preflight_request