Bartosz Różański

@nkryuchkov To me, it seems that a data race does not cause failure. The race detector does not report the problem. I think the test is generally flaky because of...

### Summary of my observations so far: When the `bookchecker` queries for peers that are unavailable for X period of time, it checks the `LastSeen` property of a `knownAddress`. This...

@moshababo What about `CommitmentATX`? It's part of the `NIPostChallenge` at the moment: https://github.com/spacemeshos/go-spacemesh/blob/9d921e4bcd0ef884cc4a5e60f081f16f207c4c8c/common/types/activation.go#L100-L111

@moshababo, I have a few questions: > It needs to be added as well (I didn't mention it because it didn't exist at the time I wrote the proposal). Could...

@moshababo few more questions: --- > Calculate Sequence according to the prev ATX's Sequence. Why not just pass the sequence in the challenge data? --- > Calculate the challenge hash...

@fasmat I was looking for options to validate structures for my other PR and I stumbled upon https://github.com/go-playground/validator. It allows for a declarative definition of validation rules for each struct...

@dshulyak > i don't think that operator should be aware that we have p2p.bootstrap component or p2p.pubsub, it can get removed or updated and it will require changes in the...

> > In order to hide the implementation details from the config, I can embed these structures in the main p2p Config instead of having separate fields. > > i...

@dshulyak, I embedded `pubsub`, `discovery` and `bootstrap` to hide them from an operator.

> Pending design proposal by @noamnelke. The design was proposed in https://community.spacemesh.io/t/redundant-poet-registration/310/1