Pooria Ghaedi comments

Results 20 comments of


                                            Pooria Ghaedi

Fix: Change warning to error when incorrect type is used for mocking a resource (#1839)

Hey @janosdebugs, thanks for giving me the opportunity. Sure will do.

Fix: Change warning to error when incorrect type is used for mocking a resource (#1839)

@ollevche Can you please review the code? If you approve, I will start working to write the tests.

Fix: Change warning to error when incorrect type is used for mocking a resource (#1839)

@ollevche Sorry, My changes were not pushed to this repo. Can you please check again?

Fix: Change warning to error when incorrect type is used for mocking a resource (#1839)

@ollevche Thanks for the feedbacks, can you check the changes please?

Fix: Change warning to error when incorrect type is used for mocking a resource (#1839)

> @pooriaghaedi looks like there is a failing test Should I modify the tests?

Fix: Change warning to error when incorrect type is used for mocking a resource (#1839)

Hi @ollevche, are you working on this yourself?

Testing: When mocking a resource, wrong type for the resource field doesn't fail, simply ignores mock

@cam72cam Can you please assign it to me and also give me some directions?

Testing: When mocking a resource, wrong type for the resource field doesn't fail, simply ignores mock

Hi @ollevche, I have tested the same code with ```v1.9.0-alpha1``` version and I get the following response: ```hcl tests/my-test.tftest.hcl... fail run "test"... fail ╷ │ Warning: Ignored mock/override field `domain_validation_options`...

Fix: flow log warning issue

@drewmullen Thanks for the reply. The main issue comes from the Cloud WAN module, which warns us all the time while we are not using the flow logs at all....

[Feature]: `corefunc_url_decode`

@skyzyx Could you please assign this task to me? I've already written the code.