Poliorcetics

Results 207 comments of Poliorcetics

What's missing for a release of v0.4 ? I see all the TODOs are checked

@estebank (since you're marked as reviewer) I'm stuck here, if you have any guidance I'm interested 😅 (but it's not urgent, don't worry !)

Thanks for the help ! It's much better now but I have duplicated diagnostics in the `fold` case from my original example now and I have not found a way...

Hm, my change suggests to add a `;` after the `dummy()` call in this code: ```rust async fn caller() { dummy() // suggest `;` here (.await is also suggested) }...

Failing test is due to a connection error.

Sorry for the long wait, I rebased and fixed your comment

I have not managed to reproduce either on macOS and have been using both pickers since they were added to master, so I second the-mikedavis, it's probably a windows-specific bug

Wow good find, that explains why reproducing it failed on macOS and Linux. On the [`std::path`](https://doc.rust-lang.org/std/path/index.html), the docs say: > [Case sensitivity](https://doc.rust-lang.org/std/path/index.html#case-sensitivity) > > Unless otherwise indicated path methods that...

After some exploration, it could be somewhat hard to fix properly. The following program consider the `C:`/`c:` a `Normal` path component on Windows, not a `Prefix`: ```rust use std::path::Path; fn...

I just submitted a PR to fix this. I don't use a Windows machine outside of VMs so if someone who does could test this works for them that would...